Comments on: Setting up SVNSync and SVN-Notify

By: Joseph Scott

Joseph Scott — Mon, 29 Mar 2010 22:05:50 +0000

Yeah, I need to play with this a bit more and see if I can make it work again.

By: westi

westi — Mon, 29 Mar 2010 18:46:58 +0000

You may need a longer delay before the notifier runs so as to ensure you are not catching the svnsync username.

You could make it check the username and loop if the username for the revision is still svnsync.

By: westi

westi — Mon, 29 Mar 2010 18:45:27 +0000

If you enable the ability to edit rev-props using a hook in the repo (which I think you have to do for svnsync anyway) then you can easily change the username associated with a log message.

You can do this as a one time script which runs through each revision on write a hook to do it for each revision as it is synced (as long as you can hook in after svnsync has set the username)

By: Joseph Scott

Joseph Scott — Mon, 29 Mar 2010 15:05:06 +0000

Peter Westwood’s suggestion worked for awhile, but for some reason has stopped working for me. This could be due to changes on the main repo, I’m not sure.

I’m not aware of specific method for changing usernames with svn hooks, but I wouldn’t be surprised if someone has done that before.

By: Øystein K. Stephansen

Øystein K. Stephansen — Mon, 29 Mar 2010 12:33:34 +0000

Hi!

Did you sort the issue regarding that all commits where done by the user running svnsync?

I’m trying to move my subversion from an online service to our own local network and all commits are done by the user running the svnsync. And to make it even harder all the usernames have changed from the old repository to the new one.

Do you know of any way to change the usernames with svn hooks? On the external online service we use our complete mail address as usernames but the local one only use the domain username. So I need to strip away “@domain.com” in the username that does the commit……

Any ideas?

By: westi

westi — Sat, 16 Jan 2010 23:05:57 +0000

Cool.

I guess the output redirect difference may be just a shell configuration thing.

I just googled what to use as I can never remember ;-)

By: Joseph Scott

Joseph Scott — Sat, 16 Jan 2010 23:02:35 +0000

Nice!
I had to make just one small fix, I changed the last line to:

delayed_notify $1 $2 >&2 /dev/null &

Without that I’d get an error, post-commit: 28: Syntax error: Bad fd number
I guess it doesn’t assume STDERR.

Not a big deal, but I usually do the ordering on this differently: > /dev/null 2>&1
so that it reads out loud like, redirect STDOUT to /dev/null and redirect STDERR to STDOUT

Thanks again, I just confirmed that this works. I now get the correct username in the commit emails. I’ll update the post with your example.

By: westi

westi — Sat, 16 Jan 2010 12:11:41 +0000

This will do it.

This will fork and sleep before doing the notify so that you catch the revprop changes as well.

You need to tune the sleep time based on how big the revprop changes take. 10 seconds is probably far too long.

#!/bin/sh


delayed_notify() {

        sleep 10

        /usr/bin/svnnotify --repos-path "$1" --revision "$2" \

        --to commit-list@example.com \

        --from commit-list@example.com \

        --with-diff \

        --subject-cx \

        --subject-prefix 'REPO-NAME ' \

        --handler HTML::ColorDiff

}

delayed_notify $1 $2 >& /dev/null &

By: Joseph Scott

Joseph Scott — Fri, 15 Jan 2010 23:39:30 +0000

So your thought is that SVN-Notify is running late enough to pick up the commit, but not late enough to pick prop changes, interesting. I wonder if there is something in svnsync that I could use to call SVN-Notify directly, after svnsync has completed replaying all of the changes.

I’ll have to explore this further, I’d really like to get all of the accurate information in the commit emails when using this setup.

By: westi

westi — Fri, 15 Jan 2010 22:13:07 +0000

The trick to get the correct usernames and dates is going to be to run your script later.

svnsync works by doing a commit and then playing with the revprops to set username, date etc which is why it needs the pre-revprop-change hook.

You want svn-notify to run after it has done all this.

You probably need something which runs n-seconds after the commit triggered from post-revprop-change and does the notify that way.

Barry may have some hints as the WP.org trac runs against an svnsync’d copy of the code.