Comments on: MakeItLink – Detecting URLs In Text And Making Them Links

By: Joseph Scott

Joseph Scott — Mon, 09 Feb 2009 22:06:18 +0000

We welcome patches :-)

By: Ryan

Ryan — Mon, 09 Feb 2009 20:49:34 +0000

Hi,

I tested again and you are partially right. This case:

“My site (http://josephscott.org)”

still did not work but this did:

“My site (http://josephscott.org) period.”

So I added a trailing space character to the string on line 41 and that seemed to fix the problem.

I am having trouble deciphering that regex. Can we not find a solution where line 41 looks like:

“{$text}”

instead of:

” {$text} ”

thx

By: Joseph Scott

Joseph Scott — Mon, 09 Feb 2009 18:35:42 +0000

Multiple people have indicated that this code is working. Can you confirm that your copied code is the same as what I posted?

By: Ryan

Ryan — Sat, 07 Feb 2009 21:50:24 +0000

Hi again,

I have reconstructed the wordpress make_clickable code to try and get this to work and it still does not work(at least on a PHP4 engine).

Please see MakeItLink2.php and MakeItLink3.php which can be found in this zip:

http://pinchpile.com/makelink.zip

MakeItLink2.php is a class for making links without taking parens into consideration. This works as expected.

MakeItLink3.php is a class for taking parens into account as coded in the leaner version diff for ticket 8300. This code still does not work for(on PHP4 at least) this test case:

My site (http://josephscott.org)

Can you test it on PHP 4/5 and get back to me? Thanks.

By: Ryan

Ryan — Sat, 07 Feb 2009 20:39:25 +0000

Hi,

I copied the code to my clipboard and pasted it to a PHP file. Then I removed the protected/public keywords because I have PHP4. I started testing it and it does not work for a link in parens that has no parens. The ending closing paren is included as part of the link. This is the example I was testing(hopefully it will render properly):

My site (http://josephscott.org)

If it doesn’t render properly it is this case:

(link)

Can you test this with a PHP4 version of MakeItLink? And if it works for you can you post a link to your actual class file?

By: Eric Meyer

Eric Meyer — Mon, 08 Dec 2008 03:15:37 +0000

Perfecto-- works great! Thanks much. I may integrate this into my Latest Tweet plugin, depending on how much effort it will take to do so and still support the URL-shortening feature.

By: Joseph Scott

Joseph Scott — Sun, 07 Dec 2008 06:14:54 +0000

Sorry, this appears to completely my fault. Not sure when/where, but I managed to completely botch that regex line. I’ve updated the code in the post with the correct regex line. I tried the corrected version (minus the protected/public keywords) with PHP4 and confirmed that it works now.

My apologies for the confusion.

By: Joseph Scott

Joseph Scott — Sat, 06 Dec 2008 23:08:37 +0000

I take that back, it looks like something did change in PHP5 for preg_replace_callback that causes it to break in PHP4.

By: Joseph Scott

Joseph Scott — Sat, 06 Dec 2008 21:25:03 +0000

It does have PHP5′isms in it (such as the protected and public keywords), but there really isn’t anything in the code that requires PHP5.

By: Eric Meyer

Eric Meyer — Sat, 06 Dec 2008 19:07:28 +0000

Is this library PHP5 only? I got a bunch of errors testing it out, some of which I banished by stripping off the ‘protected’ and ‘public’ function labels, but even after that I ended up with a preg_replace_callback error I couldn’t resolve.

(And before anyone says “Just upgrade PHP already!”, that’s not always an available option.)